Refactor Sets/Maps/Lists MethodHandle dispatch for full branch coverage on any JDK#259
Merged
mercyblitz merged 1 commit intodevfrom Mar 19, 2026
Merged
Conversation
…anch coverage Co-authored-by: mercyblitz <533114+mercyblitz@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mercyblitz
March 19, 2026 13:14
View session
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




On JDK 8, the
Set/Map/List.of(...)MethodHandles arenullat class load time, making theinvokeExactbranch unreachable in tests. On JDK 9+, the null-guard branch is never hit. Neither branch achieves full coverage under a single JDK version.Approach
Extract the MethodHandle dispatch logic from each public factory method into a package-private helper that accepts the handle as an explicit parameter. The public method becomes a one-liner delegate.
Before:
After:
Tests can now exercise both branches unconditionally by injecting
nullor a type-incompatible handle:Changes
Sets.java— extractedofSet0–ofSet10andofSetElementshelpersMaps.java— extractedofMap0–ofMap10andofMapEntrieshelpersLists.java— extractedofList0–ofList10andofListElementshelpersSetsTest/MapsTest/ListsTest— added null + wrong-handle tests for every helper (114 tests total)